Robin CASSET has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 )
Change subject: mb/ongy/h61m-s1: Add new mainboard {LGA1155,H61} ......................................................................
Patch Set 25:
(11 comments)
Patch Set 24:
(10 comments)
https://review.coreboot.org/c/coreboot/+/40813/24//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40813/24//COMMIT_MSG@7 PS24, Line 7: mb/ongy/h61m-s1: Add new mainboard
Mention the socket/chipset in the summary, so people can better classify the device at first look.
Done
https://review.coreboot.org/c/coreboot/+/40813/24//COMMIT_MSG@7 PS24, Line 7: ongy
I have never heard of them.
Done
https://review.coreboot.org/c/coreboot/+/40813/24//COMMIT_MSG@9 PS24, Line 9: Port done with the autoport utility
Please add a dot/period at the end.
Done
https://review.coreboot.org/c/coreboot/+/40813/24//COMMIT_MSG@10 PS24, Line 10:
As there is no documentation added, please mention how to flash the image. […]
Done
https://review.coreboot.org/c/coreboot/+/40813/24//COMMIT_MSG@14 PS24, Line 14: 4.15.0-99-generic
I thought that is the Linux kernel for 16.04.
Done
https://review.coreboot.org/c/coreboot/+/40813/24//COMMIT_MSG@25 PS24, Line 25: - Tianocore payload (CorebootPayload)
What is the error?
Done
https://review.coreboot.org/c/coreboot/+/40813/24/src/mainboard/ongy/Kconfig File src/mainboard/ongy/Kconfig:
https://review.coreboot.org/c/coreboot/+/40813/24/src/mainboard/ongy/Kconfig... PS24, Line 1:
Please remove the blank line.
Done
https://review.coreboot.org/c/coreboot/+/40813/24/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/acpi/platform.asl:
https://review.coreboot.org/c/coreboot/+/40813/24/src/mainboard/ongy/h61m-s1... PS24, Line 5: */
Please format the comment correctly. […]
Done
https://review.coreboot.org/c/coreboot/+/40813/24/src/mainboard/ongy/h61m-s1... PS24, Line 11: /*The _WAK method is called on system wakeup*/
Please add spaces.
Done
https://review.coreboot.org/c/coreboot/+/40813/24/src/mainboard/ongy/h61m-s1... PS24, Line 15: Return(Package(){0,0})
Please add spaces. Current autoport should have fixed this.
Done
https://review.coreboot.org/c/coreboot/+/40813/24/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/mainboard.c:
https://review.coreboot.org/c/coreboot/+/40813/24/src/mainboard/ongy/h61m-s1... PS24, Line 9: install_intel_vga_int15_handler
I'm not sure if you need this as your maindoard is a disktop.
it is used in other H61 mainboards: https://github.com/coreboot/coreboot/blob/master/src/mainboard/gigabyte/ga-h...