Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41390 )
Change subject: mb/lenovo/x230: Fix issues detected after 6b95507e is merged
......................................................................
Patch Set 11:
Patch Set 6:
Patch Set 6:
Why not make one commit per logical change? I’d prefer that.
I prefer it too. The problem is, before more issues can be detected, 6b95507e got merged.
I understood. But I meant, as Lynxis now pointed out too, that the fix-ups in this change-sets should be added as one commit per each logical fix, and not all together.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41390
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id59cdc5479aaf70809dd1ca613056263661455eb
Gerrit-Change-Number: 41390
Gerrit-PatchSet: 11
Gerrit-Owner: Bill XIE
persmule@hardenedlinux.org
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 18 May 2020 09:38:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment