Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40563 )
Change subject: soc/intel/common: Trigger recovery mode for CSE Lite SKU run time errors ......................................................................
Patch Set 12:
(5 comments)
https://review.coreboot.org/c/coreboot/+/40563/11/src/soc/intel/common/block... File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/40563/11/src/soc/intel/common/block... PS11, Line 5: <security/vboot/misc.h>
nit: Put this below along with security/vboot/vboot_common. […]
Done
https://review.coreboot.org/c/coreboot/+/40563/11/src/soc/intel/common/block... PS11, Line 9:
#include <vb2_api.h> […]
Done
https://review.coreboot.org/c/coreboot/+/40563/11/src/soc/intel/common/block... PS11, Line 43: *
Can you also add: […]
Ack
https://review.coreboot.org/c/coreboot/+/40563/11/src/soc/intel/common/block... PS11, Line 146: VB2_RECOVERY_INTEL_CSE_LITE_SKU
This is going to require an uprev of vboot in coreboot: https://review.coreboot. […]
Ack
https://review.coreboot.org/c/coreboot/+/40563/11/src/soc/intel/common/block... PS11, Line 150: do_global_reset();
I think we can just add a die("") here. This condition is not really expected.
Ack