Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39906 )
Change subject: drivers/pc80/rtc: Always load cmos.default if measured boot is enabled
......................................................................
Patch Set 5: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/39906/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/39906/1//COMMIT_MSG@13
PS1, Line 13: unconditional
Where had I better to write it down?
The if(CONFIG(MEASURED_BOOT) ... Seems a good starting point.
For PCR precalculations it must be specified what is measured and when, but that's out of scope of this commit.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39906
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If6ea0d1cbaa7d96f7dea7e77b7548ca2b30efe9e
Gerrit-Change-Number: 39906
Gerrit-PatchSet: 5
Gerrit-Owner: Bill XIE
persmule@hardenedlinux.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 30 Mar 2020 18:04:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Bill XIE
persmule@hardenedlinux.org
Comment-In-Reply-To: Patrick Rudolph
siro@das-labor.org
Gerrit-MessageType: comment