Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31096 )
Change subject: soc/intel/cannonlake: set SaGv_Enabled to 3 for CFL
......................................................................
Patch Set 1:
(1 comment)
I didn't see this when I made CB:31095
https://review.coreboot.org/#/c/31096/1/src/soc/intel/cannonlake/chip.h
File src/soc/intel/cannonlake/chip.h:
https://review.coreboot.org/#/c/31096/1/src/soc/intel/cannonlake/chip.h@112
PS1, Line 112: IS_ENABLED(CONFIG_SOC_INTEL_CANNONLAKE)
Is this needed? It defaults to y for CNL/CFL/WHL
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31096
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3c059c259239196e2fe0a2ecad6b7babad6de2ff
Gerrit-Change-Number: 31096
Gerrit-PatchSet: 1
Gerrit-Owner: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: John Su
john_su@compal.corp-partner.google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Fri, 25 Jan 2019 19:29:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment