Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48069 )
Change subject: mb/google/brya: Enable ACPI and add ACPI table ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/48069/3/src/mainboard/google/brya/d... File src/mainboard/google/brya/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/48069/3/src/mainboard/google/brya/d... PS3, Line 15: #include <soc/intel/common/acpi/platform.asl> : /* global NVS and variables */ : #include <soc/intel/common/block/acpi/acpi/globalnvs.asl> : /* CPU */ : #include <cpu/intel/common/acpi/cpu.asl> nit: blank lines between
https://review.coreboot.org/c/coreboot/+/48069/3/src/mainboard/google/brya/d... PS3, Line 27: /* Chipset specific sleep states */ nit: blank line after last `}`
https://review.coreboot.org/c/coreboot/+/48069/3/src/mainboard/google/brya/m... File src/mainboard/google/brya/mainboard.c:
https://review.coreboot.org/c/coreboot/+/48069/3/src/mainboard/google/brya/m... PS3, Line 25: dev->ops->acpi_inject_dsdt = chromeos_dsdt_generator; should this go in CB:48111?