Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36272 )
Change subject: Program loading: Handoff cbmem_top via calling arguments ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36272/1/src/arch/x86/postcar_loader... File src/arch/x86/postcar_loader.c:
https://review.coreboot.org/c/coreboot/+/36272/1/src/arch/x86/postcar_loader... PS1, Line 228: prog_set_arg(&prog, cbmem_top());
where does postcar pick this up?
CB:36274 exit_car.S
https://review.coreboot.org/c/coreboot/+/36272/1/src/lib/prog_loaders.c File src/lib/prog_loaders.c:
https://review.coreboot.org/c/coreboot/+/36272/1/src/lib/prog_loaders.c@147 PS1, Line 147: /* This overrides the arg fetched from the relocatable module */
You should indicate that it doesn't matter. But you could also do what you want by having a ramstage module parameters section for x86 and just setting the parameter in load_relocatable_ramstage(). Hrmm. Looks like we still have some random x86 platforms that don't use relocatable ramstage. Ugh.
I opted for passing cbmem_top via calling args as it should be possible to have a single cbmem_top implementation for all architectures regardless of relocatable ramstage.