Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34381 )
Change subject: security/tpm/tss: Add support for PTT
......................................................................
Patch Set 15:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34381/12/src/security/tpm/tss/tcg-2...
File src/security/tpm/tss/tcg-2.0/tss.c:
https://review.coreboot.org/c/coreboot/+/34381/12/src/security/tpm/tss/tcg-2...
PS12, Line 195: if (CONFIG(HAVE_INTEL_PTT)) {
[not resolved]
I'm not sure about whether tis_open or tis_init would fail or not. The Intel PTT BIOS Writers Guide states that this should be done prior sending a TPM Command. But anyways - we can move it from the TSS Layer to the TIS Layer if that is fine with everyone.
My point was, that if Intel decides to support more interface (because logically the ME sits in the SB, which is also connected via LPC - so LPC would also be an option here), we have to integrate this into more interfaces.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34381
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3b262a5d5253648fb96fb1fd9ba3995f92755bb1
Gerrit-Change-Number: 34381
Gerrit-PatchSet: 15
Gerrit-Owner: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 30 Jul 2019 08:22:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
siro@das-labor.org
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Christian Walter
christian.walter@9elements.com
Gerrit-MessageType: comment