[coreboot-gerrit] Change in coreboot[master]: helios: Add TEMP_SENSOR4 to DPTF

[Paul Fagerburg (Code Review)]

Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35920 )

Change subject: helios: Add TEMP_SENSOR4 to DPTF
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35920/1/src/mainboard/google/hatch/... 
File src/mainboard/google/hatch/variants/helios/include/variant/acpi/dptf.asl:

https://review.coreboot.org/c/coreboot/+/35920/1/src/mainboard/google/hatch/... 
PS1, Line 57: #define DPTF_TSR3_SENSOR_ID	3
            : #define DPTF_TSR3_SENSOR_NAME	"CPU"
            : #define DPTF_TSR3_PASSIVE	85
            : #define DPTF_TSR3_CRITICAL	100
            : #define DPTF_TSR3_ACTIVE_AC0	0
            : #define DPTF_TSR3_ACTIVE_AC1	0
            : #define DPTF_TSR3_ACTIVE_AC2	0
            : #define DPTF_TSR3_ACTIVE_AC3	0
            : #define DPTF_TSR3_ACTIVE_AC4	0
            : #define DPTF_TSR3_ACTIVE_AC5	0
            :
> The values that are all 0 -- Is it okay to skip setting them?

After looking at the underlying code with you and Tim, I think we need to define these anyway.
Also, future platform tuning will change those values, so we having them defined now means we have nice placeholders for future use.