[coreboot-gerrit] Change in coreboot[master]: src/soc/intel/{common,cnl,skl,icl}: Move global reset req function to...

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35228 )

Change subject: src/soc/intel/{common,cnl,skl,icl}: Move global reset req function to common
......................................................................

Patch Set 25:

(2 comments)

https://review.coreboot.org/c/coreboot/+/35228/25/src/soc/intel/common/block... 
File src/soc/intel/common/block/cse/cse.c:

https://review.coreboot.org/c/coreboot/+/35228/25/src/soc/intel/common/block... 
PS25, Line 577: The reset type can be GLOBAL_RESET/
              :  * HOST_RESET_ONLY/CSE_RESET_ONLY.
> Yes, The spec does not mention about the different resets for this command. […]

So, is it supported on all platforms? Or just some?

https://review.coreboot.org/c/coreboot/+/35228/25/src/soc/intel/common/block... 
PS25, Line 609: 	if (rst_type == CSE_RESET_ONLY)
> for CSE_RESET_ONLY, there will not be a response.

So, I am a bit confused. In case of global reset, wouldn't a response mean that the global reset failed?