Attention is currently required from: Martin Roth, jacz@semihalf.com, Jan Dabros.
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50305 )
Change subject: tests: Add lib/stack-test test case
......................................................................
Patch Set 2:
(1 comment)
File tests/lib/stack-test.c:
https://review.coreboot.org/c/coreboot/+/50305/comment/acd1fd78_0753a67a
PS1, Line 102: stack[i] = 0x42420707;
the stack should have even size
I hadn't thought of that case. In my experience, stacks are always an even number of bytes, but that's not a requirement.
Please change the code back to what you had before, so that it won't overflow if STACK_SIZE is odd.
Sorry for the churn.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50305
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icf0cceac290618a50ecc4e65f1f9551dbf31bd32
Gerrit-Change-Number: 50305
Gerrit-PatchSet: 2
Gerrit-Owner: jacz@semihalf.com
Gerrit-Reviewer: Jan Dabros
jsd@semihalf.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: jacz@semihalf.com
Gerrit-Attention: Jan Dabros
jsd@semihalf.com
Gerrit-Comment-Date: Mon, 08 Feb 2021 14:57:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: jacz@semihalf.com
Comment-In-Reply-To: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-MessageType: comment