Attention is currently required from: Michał Żygowski, Elyes Haouas, Felix Held, Piotr Król.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70255 )
Change subject: superio/nuvoton/nct5104d/chip.h: Use 'bool' when appropriate
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
I think it's proper to keep 1/0 by the comment, it's bit wise register value.
IRQ type selection (1:level,0:edge)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/70255
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idb321302bc82eb1b73bc1e732b82b9f726d2f363
Gerrit-Change-Number: 70255
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Attention: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Comment-Date: Fri, 02 Dec 2022 14:26:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment