Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44868 )
Change subject: sc7180 : report hardware watchdog reset after reboot ......................................................................
Patch Set 9:
(5 comments)
https://review.coreboot.org/c/coreboot/+/44868/9/src/soc/qualcomm/sc7180/inc... File src/soc/qualcomm/sc7180/include/soc/clock.h:
https://review.coreboot.org/c/coreboot/+/44868/9/src/soc/qualcomm/sc7180/inc... PS9, Line 134: u32 aoss_cc_apcs_misc; Might be good to add a check_member() for this one.
https://review.coreboot.org/c/coreboot/+/44868/9/src/soc/qualcomm/sc7180/inc... File src/soc/qualcomm/sc7180/include/soc/watchdog.h:
https://review.coreboot.org/c/coreboot/+/44868/9/src/soc/qualcomm/sc7180/inc... PS9, Line 8: #endif // _SOC_QUALCOMM_SC7180_WDOG_H__ Please use /* C89 comments */
https://review.coreboot.org/c/coreboot/+/44868/9/src/soc/qualcomm/sc7180/soc... File src/soc/qualcomm/sc7180/soc.c:
https://review.coreboot.org/c/coreboot/+/44868/9/src/soc/qualcomm/sc7180/soc... PS9, Line 27: volatile unsigned int aoss = *(unsigned int *)AOSS_CC_RESET_STATUS; Everything in this file is now no longer used and should be deleted, right?
https://review.coreboot.org/c/coreboot/+/44868/9/src/soc/qualcomm/sc7180/wat... File src/soc/qualcomm/sc7180/watchdog.c:
https://review.coreboot.org/c/coreboot/+/44868/9/src/soc/qualcomm/sc7180/wat... PS9, Line 11: uint32_t wdog_sta;
code indent should use tabs where possible
Please fix all these formatting warnings.
https://review.coreboot.org/c/coreboot/+/44868/9/src/soc/qualcomm/sc7180/wat... PS9, Line 14: printk(BIOS_INFO, "\nWDOG: Last reset was AOSS_CC_RESET_STATUS : %x\n", wdog_sta & WDOG_RESET_BIT_MASK); The eventlog code already prints a message when it's logging the event so this doesn't really add anything else, I don't think we need it.