Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31448 )
Change subject: src/device/pci: Add support for discrete VGA initialization and OpROM loading ......................................................................
Patch Set 14:
(1 comment)
https://review.coreboot.org/#/c/31448/14/src/device/pci_rom.c File src/device/pci_rom.c:
https://review.coreboot.org/#/c/31448/14/src/device/pci_rom.c@276 PS14, Line 276: if (CONFIG(MULTIPLE_VGA_ADAPTERS)) : return current; : /* Write ACPI VFCT only for Discrete VGA. */ : /* TODO: do this also for Integrated VGA. */ : break; : case PCI_CLASS_DISPLAY_OTHER: : if (!CONFIG(MULTIPLE_VGA_ADAPTERS)) : return current; : break;
I don't know how much time it'll take to implement the alternative solution, and for the coreboot us […]
Getting code upstream is about working on nice and maintainable solutions to problems and getting feedback on how to achieve that. Getting hardware to work is nice ofc, but not sufficient reason to accept it upstream. If you don't want to work on it anymore, users can still get your patches.
If you have questions about the suggestions made in https://review.coreboot.org/c/coreboot/+/31502 , I and others are very willing to answer them. It might also be a good idea to look at the vendor ACPI code to figure out what it does?