Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48479 )
Change subject: mb/google/guybrush: Add new mainboard ......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/c/coreboot/+/48479/7/src/mainboard/google/guybru... File src/mainboard/google/guybrush/board_info.txt:
https://review.coreboot.org/c/coreboot/+/48479/7/src/mainboard/google/guybru... PS7, Line 6: n
This is likely due to flashrom searching for MB/Part# in the .id section at the end of the image. […]
Zork can probably be updated now. Flashrom didn't work on picasso when the initial board_info.txt file was pushed. Until we can test it on cezanne, it's hard to say whether it will work there or whether flashrom needs to be updated to support a new ID. Obviously we'll get it working before the board is released, so I'm fine with having this set either way.
https://review.coreboot.org/c/coreboot/+/48479/8/src/mainboard/google/guybru... File src/mainboard/google/guybrush/mainboard.c:
https://review.coreboot.org/c/coreboot/+/48479/8/src/mainboard/google/guybru... PS8, Line 3: nit: remove extra line