Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38179 )
Change subject: drivers/pc80/rtc: Clean up some inlined functions ......................................................................
Patch Set 1:
(3 comments)
Thank you for the clean-up.
https://review.coreboot.org/c/coreboot/+/38179/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38179/1//COMMIT_MSG@8 PS1, Line 8: Could you please document, why you added the checks?
if (control_state & RTC_SET)
https://review.coreboot.org/c/coreboot/+/38179/1/src/drivers/pc80/rtc/mc1468... File src/drivers/pc80/rtc/mc146818rtc.c:
https://review.coreboot.org/c/coreboot/+/38179/1/src/drivers/pc80/rtc/mc1468... PS1, Line 87: cmos CMOS
https://review.coreboot.org/c/coreboot/+/38179/1/src/drivers/pc80/rtc/mc1468... PS1, Line 417: /* Upon return the caller is guaranteed 244 microseconds to complete any Please use
/* * Upon …