Attention is currently required from: Julius Werner, Tim Wawrzynczak.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59877 )
Change subject: cbfstool: Fix offset calculation for aligned files
......................................................................
Patch Set 2: Code-Review+1
(3 comments)
Patchset:
PS2:
Thanks for cleaning that up. I can abandon CB:56432 and CB:56433
File util/cbfstool/cbfstool.c:
https://review.coreboot.org/c/coreboot/+/59877/comment/6744b26f_6ad1d163
PS2, Line 1085: *offset;
Do we also need to convert the address here?
https://review.coreboot.org/c/coreboot/+/59877/comment/66c59bed_7570e1dc
PS2, Line 1299: param.filename,
: param.name,
: param.headeroffset,
If we are just using the param global, do we even need these parameters?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59877
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia49a585988f7a74944a6630b77b3ebd79b3a9897
Gerrit-Change-Number: 59877
Gerrit-PatchSet: 2
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Georgi
patrick@coreboot.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Comment-Date: Mon, 06 Dec 2021 17:37:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment