Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48360 )
Change subject: mb/intel/coffeelake_rvp/var/cfl_u: Add empty verb table
......................................................................
Patch Set 2:
Patch Set 2:
Empty c files instead of empty headers? How does that make a difference? The right way is to have no files when none are required -> fix the build system
I don't think he meant replacing the header file by an empty C file.
#include "variant/hda_verb.h"
This is from mb/intel/coffeelake_rvp/hda_verb.c, which requires every variant to have such a header file. I think what he suggested was to move the hda_verb.c to the variant directories and add them to their Makefile.inc, if needed.
That's not what I understood from the commit message tbh
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48360
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I00d968563539a4e1b8d1e12145293439d8358555
Gerrit-Change-Number: 48360
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 08 Dec 2020 16:40:36 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment