Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42503 )
Change subject: post_code: replace postcode values with their respective defined constants
......................................................................
Patch Set 9:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42503/9/src/cpu/intel/car/non-evict...
File src/cpu/intel/car/non-evict/exit_car.S:
https://review.coreboot.org/c/coreboot/+/42503/9/src/cpu/intel/car/non-evict...
PS9, Line 15: POST_CAR_CACHE_DISABLE
That post code had been already used in bootblock
https://review.coreboot.org/c/coreboot/+/42503/9/src/cpu/intel/car/non-evict...
PS9, Line 28: POST_CAR_CACHE_EVICTION
That postcode had been already used in bootblock and had a different meaning. Note here it's turned off, while it was turned on in bootblock. Please add a new postcode for postcard stage/car teardown
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42503
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If32f43104a829bd1db0d5f5340cc94bf0c717c39
Gerrit-Change-Number: 42503
Gerrit-PatchSet: 9
Gerrit-Owner: Sindhoor Tilak
sindhoor@sin9yt.net
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Lee Leahy
leroy.p.leahy@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Comment-Date: Tue, 07 Jul 2020 05:27:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment