Attention is currently required from: David Wu, Zhuohao Lee, Alan Huang.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58105 )
Change subject: mb/google/brya/var/brask: Configurate the GPIOs of LAN
......................................................................
Patch Set 6:
(1 comment)
File src/mainboard/google/brya/variants/brask/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/58105/comment/c1d1f403_f7265f90
PS5, Line 86: register "stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_H22)"
From 8125 spec., this pin will not disable wake-on-lan. We will double check it.
So this PowerResource will look sorta like this:
Method (_ON, 0)
{
// drive GPP_H22 high
// sleep for 12 ms
}
and this is the LAN's ISOLATE pin, which is active low, so I think this is right?
PERST is connected to PLTRST# and power is controlled by the S5 rails.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58105
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2e82dbc1e6c68cbd84b603adc7fdc3ee1d4d3392
Gerrit-Change-Number: 58105
Gerrit-PatchSet: 6
Gerrit-Owner: Alan Huang
alan-huang@quanta.corp-partner.google.com
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Attention: Zhuohao Lee
zhuohao@google.com
Gerrit-Attention: Alan Huang
alan-huang@quanta.corp-partner.google.com
Gerrit-Comment-Date: Wed, 10 Nov 2021 18:49:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Zhuohao Lee
zhuohao@google.com
Comment-In-Reply-To: Alan Huang
alan-huang@quanta.corp-partner.google.com
Gerrit-MessageType: comment