Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44167 )
Change subject: mb/acer/m3800: add Acer Aspire M3800 desktop ......................................................................
Patch Set 2: Code-Review+1
(4 comments)
https://review.coreboot.org/c/coreboot/+/44167/2/src/mainboard/acer/m3800/Kc... File src/mainboard/acer/m3800/Kconfig:
https://review.coreboot.org/c/coreboot/+/44167/2/src/mainboard/acer/m3800/Kc... PS2, Line 34: _ this underscore can be a space
https://review.coreboot.org/c/coreboot/+/44167/1/src/mainboard/acer/m3800/Kc... File src/mainboard/acer/m3800/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/44167/1/src/mainboard/acer/m3800/Kc... PS1, Line 2: M3800
Good idea, changed it to "M3800 / G43T-AM3". […]
I'd use: "Aspire M3800 (G43T-AM3)"
https://review.coreboot.org/c/coreboot/+/44167/1/src/mainboard/acer/m3800/de... File src/mainboard/acer/m3800/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/44167/1/src/mainboard/acer/m3800/de... PS1, Line 144: device pci 1f.1 on end # PATA/IDE
Certainly not. Looking at cbmem I can see "PCI: Static device PCI: 00:1f.1 not found, disabling it". […]
It doesn't exist on ICH10 at all
https://review.coreboot.org/c/coreboot/+/44167/1/src/mainboard/acer/m3800/ds... File src/mainboard/acer/m3800/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/44167/1/src/mainboard/acer/m3800/ds... PS1, Line 17: Scope (_SB) { : Device (PCI0) : {
Neat, I like that. […]
I don't really care. What really bothers me, though, is that the brace positioning is inconsistent 😜 I don't care if they are on the same or the next line, as long as both are the same