[coreboot-gerrit] [M] Change in coreboot[master]: soc/amd/common/psp_verstage: Map/unmap boot device on need basis

[Raul Rangel (Code Review)]

Attention is currently required from: Jason Glenesk, Matt DeVillier, Martin Roth, Fred Reitberger, Karthik Ramasubramanian, Elyes Haouas, Felix Held.

Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74606 )

Change subject: soc/amd/common/psp_verstage: Map/unmap boot device on need basis
......................................................................

Patch Set 3: Code-Review+2

(2 comments)

File src/soc/amd/common/psp_verstage/boot_dev.c:

https://review.coreboot.org/c/coreboot/+/74606/comment/e62ea6d9_a1d40dcc 
PS1, Line 42: mdev->base
> I think if it is not mapped, then we should get a page fault based on my understanding.

Great, just double checking.

https://review.coreboot.org/c/coreboot/+/74606/comment/d5abaa84_798d2fb9 
PS1, Line 34: printk
> I was suggesting making `boot_dev_munmap` return void if we aren't going to return an actual error.

`boot_dev_munmap` is registered as part of the `region_device_ops`, so we need to keep the signature.