Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40245 )
Change subject: mainboard/volteer: Update Aux settings for Port 0
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40245/5/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/40245/5/src/mainboard/google/voltee...
PS5, Line 242: /* E22 : DDPA_CTRLCLK ==> USB_C1_AUXP_DC: Retimer FW drives this pin */
: PAD_NC(GPP_E22, NONE),
: /* E23 : DDPA_CTRLDATA ==> USB_C1_AUXN_DC: Retimer FW drives this pin */
: PAD_NC(GPP_E23, NONE),
don't these need to be NF6 as well?
the only difference from C0 is that high/low settings don't
change with cable orientation because the retimer takes care
of the orientation for AUX/SBU lanes.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40245
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic81adc24d10322cc305bf0fa4c38514468ea0942
Gerrit-Change-Number: 40245
Gerrit-PatchSet: 5
Gerrit-Owner: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Duncan Laurie
dlaurie@chromium.org
Gerrit-CC: Paul Ma
magf@bitland.com.cn
Gerrit-Comment-Date: Mon, 11 May 2020 22:57:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment