Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36145 )
Change subject: arch/arm: Pass cbmem_top to ramstage via calling argument
......................................................................
Patch Set 16:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36145/16/src/arch/arm/stages.c
File src/arch/arm/stages.c:
https://review.coreboot.org/c/coreboot/+/36145/16/src/arch/arm/stages.c@34
PS16, Line 34: if (!ENV_ROMSTAGE)
This needs to be either ENV_RAMSTAGE or !ENV_ROMSTAGE_OR_BEFORE. We don't want it in pre-RAM verstage.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36145
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If31f0f1de17ffc92c9397f32b26db25aff4b7cab
Gerrit-Change-Number: 36145
Gerrit-PatchSet: 16
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-Comment-Date: Tue, 29 Oct 2019 23:35:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment