Attention is currently required from: Subrata Banik, Tim Wawrzynczak, Nick Vaccaro, Eric Lai. Hello build bot (Jenkins), Tim Wawrzynczak, Arthur Heymans, Nick Vaccaro, Eric Lai, Werner Zeh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/63492
to look at the new patch set (#2).
Change subject: soc/intel/fast_spi: Use `need_restore_mtrr()` to clear temp MTRR ......................................................................
soc/intel/fast_spi: Use `need_restore_mtrr()` to clear temp MTRR
`fast_spi_cache_bios_region()` is calling `set_var_mtrr()` to set temporary MTRRs with commit def18c406 (soc/intel/common/block/fast_spi: Refactor ROM caching implementation).
Hence, this patch ensures the `put_back_original_solution` variable is also getting set by `need_restore_mtrr()` after calling into the `set_var_mtrr()`. Later `remove_temp_solution()` discards any temporary MTRRs prior to boot to payload.
Ensure `need_restore_mtrr()` is called during ramstage only to set the `put_back_original_solution` variable.
BUG=b:225766934 TEST=Able to build and boot google/brya to verify that `remove_temp_solution()` is able to discard ROM caching temporary MTRRs before booting to payload.
Signed-off-by: Subrata Banik subratabanik@google.com Change-Id: I67fd36080b318ace53f3e34da53d747f9a3aa400 --- M src/soc/intel/common/block/fast_spi/fast_spi.c 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/63492/2