Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38163 )
Change subject: sb/amd/{pi,agesa}/hudson/smbus_spd.c: use coreboot code style and calls ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/38163/3/src/southbridge/amd/agesa/h... File src/southbridge/amd/agesa/hudson/smbus_spd.c:
https://review.coreboot.org/c/coreboot/+/38163/3/src/southbridge/amd/agesa/h... PS3, Line 20: /* warning: Porting.h includes an open #pragma pack(1) */ Ok.. What this does is nasty. It changes structs to __packed for the remaining of the headers. If we remove any of these, or change the include order around this, commit has to be verified for binary identity.
Please leave the comment in, but replace Porting.h with AGESA.h. The pragma gets indirectly pulled in from there.
https://review.coreboot.org/c/coreboot/+/38163/3/src/southbridge/amd/pi/huds... File src/southbridge/amd/pi/hudson/smbus_spd.c:
https://review.coreboot.org/c/coreboot/+/38163/3/src/southbridge/amd/pi/huds... PS3, Line 21: /* warning: Porting.h includes an open #pragma pack(1) */ Keep comment
https://review.coreboot.org/c/coreboot/+/38163/3/src/southbridge/amd/pi/huds... PS3, Line 23: #include <northbridge/amd/agesa/dimmSpd.h> pi