Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34505 )
Change subject: mediatek/mt8183: add a new panel configuration for Kodama ......................................................................
Patch Set 11:
(4 comments)
https://review.coreboot.org/c/coreboot/+/34505/11//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34505/11//COMMIT_MSG@7 PS11, Line 7: a You can remove the article. It’s not needed in the summary.
https://review.coreboot.org/c/coreboot/+/34505/11//COMMIT_MSG@8 PS11, Line 8: Please mention the panel name in the commit message description, and the datasheet name and revision you got the initialization sequence from.
https://review.coreboot.org/c/coreboot/+/34505/11//COMMIT_MSG@12 PS11, Line 12: Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com Please move the Signed-off-by line below the Change-Id. (The git hooks should do it that way.)
https://review.coreboot.org/c/coreboot/+/34505/11/src/mainboard/google/kukui... File src/mainboard/google/kukui/panel_kodama.c:
https://review.coreboot.org/c/coreboot/+/34505/11/src/mainboard/google/kukui... PS11, Line 342: // [0] = &AUO_??? is not ready Should this be left in here?