Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36300 )
Change subject: vboot: use vboot persistent context ......................................................................
Patch Set 9: Code-Review+2
(3 comments)
Okay, I think we can go with this and clean up the rest later!
https://review.coreboot.org/c/coreboot/+/36300/1/src/security/vboot/common.c File src/security/vboot/common.c:
https://review.coreboot.org/c/coreboot/+/36300/1/src/security/vboot/common.c... PS1, Line 55: if (wd->buffer_offset == ALIGN_UP(sizeof(*wd), 16)) {
Just to double-check that we're not going to be causing any problems: […]
Well, we can introduce another static vboot_started variable if you want. Or we could set vboot_executed right before running the vboot code rather than right after (I don't think anything relies on its value in the middle atm, but would need to double-check).
https://review.coreboot.org/c/coreboot/+/36300/7/src/security/vboot/common.c File src/security/vboot/common.c:
https://review.coreboot.org/c/coreboot/+/36300/7/src/security/vboot/common.c... PS7, Line 142: cbmem_size - wd_preram->buffer_offset,
Well that's awkward. […]
Argh... maybe just leave it incorrect then (with a comment), if it's not used at all anymore. We want to get rid of all of this anyway.
https://review.coreboot.org/c/coreboot/+/36300/9/src/security/vboot/common.c File src/security/vboot/common.c:
https://review.coreboot.org/c/coreboot/+/36300/9/src/security/vboot/common.c... PS9, Line 140: wd_cbmem->buffer_size = 0; nit: add comment why?