Attention is currently required from: Derek Huang, Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Paul Menzel, Subrata Banik, Varshit Pandya.
Yunlong Jia has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81610?usp=email )
Change subject: mb/google/nissa/var/gothrax: Add touchscreen driver for ILI2901A-A210
......................................................................
Patch Set 3:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81610/comment/86d477f5_2ae7a95e :
PS2, Line 13: TEST=emerge-nissa coreboot
How is the boot time affected?
In the experiment, the impact of this change on boot to kernel time was almost 0ms.
https://review.coreboot.org/c/coreboot/+/81610/comment/528e258f_fa86ea85 :
PS2, Line 13: TEST=emerge-nissa coreboot
were you able to check whether the touchscreen was working correctly or was it just a build test ?
Done
File src/mainboard/google/brya/variants/gothrax/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/81610/comment/5773b12a_b71f6405 :
PS2, Line 244: "300"
please check the power sequence in SPEC.
We refer to the parameters of the hid protocol
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81610?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2d26bfd4f415aa128b6256f83bc58987b15a557a
Gerrit-Change-Number: 81610
Gerrit-PatchSet: 3
Gerrit-Owner: Yunlong Jia
yunlong.jia@ecs.corp-partner.google.com
Gerrit-Reviewer: Derek Huang
derekhuang@google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyle Lin
kylelinck@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Attention: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Derek Huang
derekhuang@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Wed, 03 Apr 2024 01:41:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Varshit Pandya
pandyavarshit@gmail.com
Comment-In-Reply-To: Eric Lai
ericllai@google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment