EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37685 )
Change subject: soc/intel/cannonlake: Move GPIO PM configuration to soc level
......................................................................
Patch Set 17:
(1 comment)
Change Buffer to Package that can apply Integer. So we don't do any convert. Verified the PM bits when enter OS, before s0ix and after. Also verify after Enable PM bits as well. The result is good :) Merry X'max to you all.
https://review.coreboot.org/c/coreboot/+/37685/16/src/soc/intel/cannonlake/a...
File src/soc/intel/cannonlake/acpi/gpio.asl:
https://review.coreboot.org/c/coreboot/+/37685/16/src/soc/intel/cannonlake/a...
PS16, Line 172: GPMB[Local0] = PCRR (Local1, GPIO_MISCCFG)
to be fixed here
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37685
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I120f8369b8d3cf7ac821332bdfa124f6ed0570e9
Gerrit-Change-Number: 37685
Gerrit-PatchSet: 17
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aamir Bohra
aamir.bohra@intel.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 24 Dec 2019 08:33:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment