EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32265 )
Change subject: mb/google/hatch: Restore Goodix Touch Screen
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/#/c/32265/5//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/32265/5//COMMIT_MSG@12
PS5, Line 12:
It would be good to mention that the gpio_keys was moved to I2C1
Should I add in title? or that's ok?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32265
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic028c5d7b687a069d7f0510897bea91dca58e91f
Gerrit-Change-Number: 32265
Gerrit-PatchSet: 6
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-CC: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Van Chen
van_chen@compal.corp-partner.google.com
Gerrit-Comment-Date: Thu, 11 Apr 2019 04:21:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment