EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40567 )
Change subject: mb/google/deltaur: Move early gpio table to variants
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40567/2/src/mainboard/google/deltau...
File src/mainboard/google/deltaur/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/40567/2/src/mainboard/google/deltau...
PS2, Line 427: /* Weak implementation of early gpio */
: const struct pad_config *__weak variant_early_gpio_table(size_t *num)
: {
: *num = 0;
: return NULL;
: }
How about we just remove this from baseboard, and then move it to variants/deltaur as well? Then we […]
LGTM, will do tomorrow.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40567
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie4c4648ccf918446a499019a4f77f64e43a92c76
Gerrit-Change-Number: 40567
Gerrit-PatchSet: 2
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 21 Apr 2020 16:16:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment