Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46312 )
Change subject: soc/intel/common: Boot time optimization ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/46312/3/src/soc/intel/common/block/... File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/46312/3/src/soc/intel/common/block/... PS3, Line 630: int bool ?
https://review.coreboot.org/c/coreboot/+/46312/3/src/soc/intel/common/block/... PS3, Line 646: uint8_t bool ?
https://review.coreboot.org/c/coreboot/+/46312/3/src/soc/intel/common/block/... PS3, Line 793: uint8_t Perhaps add "CSE_LITE_SKU_NO_ERROR = 0" to the enum csme_failure_reason and then have this routine declare that it returns an enum csme_failure_reason?