[coreboot-gerrit] Change in coreboot[master]: Support for Zotac AD04 added (initial commit)

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47056 )

Change subject: Support for Zotac AD04 added (initial commit)
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/Bi... 
File src/mainboard/zotac/ad04/BiosCallOuts.c:

https://review.coreboot.org/c/coreboot/+/47056/1/src/mainboard/zotac/ad04/Bi... 
PS1, Line 37: static AGESA_STATUS board_ReadSpd_from_cbfs(UINT32 Func, UINTN Data, VOID *ConfigPtr)
            : {
            : 	AGESA_READ_SPD_PARAMS *info = ConfigPtr;
            : 
            : 	if (!ENV_ROMSTAGE)
            : 		return AGESA_UNSUPPORTED;
            : 
            : 	u8 index = get_spd_offset();
            : 
            : 	if (info->MemChannelId > 0)
            : 		return AGESA_UNSUPPORTED;
            : 	if (info->SocketId != 0)
            : 		return AGESA_UNSUPPORTED;
            : 	if (info->DimmId != 0)
            : 		return AGESA_UNSUPPORTED;
            : 
            : 	/* Read index 0, first SPD_SIZE bytes of spd.bin file. */
            : 	if (read_ddr3_spd_from_cbfs((u8*)info->Buffer, index) < 0)
            : 		die("No SPD data\n");
            : 
            : 	return AGESA_SUCCESS;
            : }
> You probably want to do what e350m1 does here instead

mb/asrock/e350m1, that is. Basically, use `agesa_ReadSpd` for the AGESA_READ_SPD callback.