Attention is currently required from: Lance Zhao, Marc Jones, Jonathan Zhang, Philipp Deppenwiese, Tim Wawrzynczak, Julius Werner, Angel Pons, Subrata Banik, Patrick Rudolph, Peter Tsung Ho Wu, Ron Minnich.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52585 )
Change subject: lib: set up specific purpose memory as LB_MEM_SOFT_RESERVED
......................................................................
Patch Set 4:
(1 comment)
File src/commonlib/include/commonlib/coreboot_tables.h:
https://review.coreboot.org/c/coreboot/+/52585/comment/ee793ac2_5b9ab64b
PS4, Line 158: #define LB_MEM_SOFT_RESERVED 0xefffffff /* Special-purpose memory */
But current lb_memory_range is not same as ACPI memory range address anyway? […]
It's not the same but by default the values are mapped 1:1. If you
don't want to have the same value in coreboot and e820. We could as
well use `7` here (or `17`; I don't know why there is a gap). And
let the code that fills the e820 table handle the mapping.
That's independent of the question if 0xefffffff is the right value
for e820 entries, though. What confuses me the most is that it is
the last value of the undefined range. So it seems unlikely that it
would become the official value later.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52585
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie70795bcb8c97e9dd5fb772adc060e1606f9bab0
Gerrit-Change-Number: 52585
Gerrit-PatchSet: 4
Gerrit-Owner: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Peter Tsung Ho Wu
tsung@amazon.com
Gerrit-Reviewer: Philipp Deppenwiese
philipp.deppenwiese@9elements.com
Gerrit-Reviewer: Ron Minnich
rminnich@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: Philipp Deppenwiese
philipp.deppenwiese@9elements.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Peter Tsung Ho Wu
tsung@amazon.com
Gerrit-Attention: Ron Minnich
rminnich@google.com
Gerrit-Comment-Date: Sun, 06 Jun 2021 16:02:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Lance Zhao
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Jonathan Zhang
jonzhang@fb.com
Gerrit-MessageType: comment