HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/25565 )
Change subject: src/cpu/intel: Add model_f6x
......................................................................
Patch Set 30:
(1 comment)
https://review.coreboot.org/#/c/25565/26/src/cpu/intel/model_f6x/model_f6x_i...
File src/cpu/intel/model_f6x/model_f6x_init.c:
https://review.coreboot.org/#/c/25565/26/src/cpu/intel/model_f6x/model_f6x_i...
PS26, Line 33: wrmsr(MSR_EBC_FREQUENCY_ID, msr_2c);
Which datasheet did you get this from? The IA32 manual I was looking at described these MSR bits 31- […]
I'm using IA32 manual
indeed 0x2c is read-only, it was just for test to understand why the value change for CPU1 after 'setup_lapic()
--
To view, visit
https://review.coreboot.org/c/coreboot/+/25565
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6003ec0f4d4245ce5fc9c1f38e555bfcfa1c22b5
Gerrit-Change-Number: 25565
Gerrit-PatchSet: 30
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Fri, 15 Feb 2019 11:57:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment