Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31213 )
Change subject: soc/intel/cannonlake: Add max uart config
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/31213/1/src/soc/intel/cannonlake/Kconfig
File src/soc/intel/cannonlake/Kconfig:
https://review.coreboot.org/#/c/31213/1/src/soc/intel/cannonlake/Kconfig@190
PS1, Line 190: SOC_INTEL_UART_DEV_MAX
its almost same kind of FSP UPD change as ICL where we will fill those LPSS UPDs as below […]
Right. I meant does it really need to be a Kconfig option though? Doing something like "#define SOC_INTEL_UART_DEV_MAX 3" would be good enough?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31213
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7a04558869f966288fae00c8a0a75433b36c9735
Gerrit-Change-Number: 31213
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Sat, 02 Feb 2019 08:45:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment