[coreboot-gerrit] Change in coreboot[master]: mb/intel/adlrvp: Refactor lpddr4_mem_config structure

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48077 )

Change subject: mb/intel/adlrvp: Refactor lpddr4_mem_config structure
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/48077/4/src/mainboard/intel/adlrvp/... 
File src/mainboard/intel/adlrvp/memory.c:

https://review.coreboot.org/c/coreboot/+/48077/4/src/mainboard/intel/adlrvp/... 
PS4, Line 25: {  0,  2,  3,  1,  6,  7,  5,  4, 10,  8, 11,  9, 14, 12, 13, 15 },
> I believe Paul had requested for this to make sure it act as an array and nothing else. […]

Yes, it doesn't make sense from a functional standpoint. Maybe not for adlrvp, but for Chrome OS board, it is very important to have this structured such that it is easy to relate it to the hardware schematics. It is helpful for partners as they add their own variants.