build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58754 )
Change subject: asus/am1i-a: fix the IRQs and create the good MP tables ......................................................................
Patch Set 1:
(15 comments)
File src/mainboard/asus/am1i-a/mainboard.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131817): https://review.coreboot.org/c/coreboot/+/58754/comment/7453f3dd_5c57674e PS1, Line 25: {GFX_DEVFN, {PIRQ_A, PIRQ_NC, PIRQ_NC, PIRQ_NC} }, /* APU Integrated Graphics: 0:01.00 - IRQ 3 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131817): https://review.coreboot.org/c/coreboot/+/58754/comment/e9983dc0_40215035 PS1, Line 26: {ACTL_DEVFN, {PIRQ_NC, PIRQ_B, PIRQ_NC, PIRQ_NC} }, /* APU HDMI Audio Controller: 0:01.01 - IRQ 4 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131817): https://review.coreboot.org/c/coreboot/+/58754/comment/cc0e1adf_967cb387 PS1, Line 27: {NB_PCIE_PORT1_DEVFN, {PIRQ_A, PIRQ_B, PIRQ_C, PIRQ_D} }, /* PCIe GPP to dGPU 1:00.00: 0:02.01 - IRQ 3 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131817): https://review.coreboot.org/c/coreboot/+/58754/comment/0dad2a6c_6c6ee7e5 PS1, Line 28: {NB_PCIE_PORT5_DEVFN, {PIRQ_B, PIRQ_C, PIRQ_D, PIRQ_A} }, /* PCIe GPP to Eth 2:00.00: 0:02.05 - IRQ 4 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131817): https://review.coreboot.org/c/coreboot/+/58754/comment/33678a42_b17676fe PS1, Line 29: {XHCI_DEVFN, {PIRQ_C, PIRQ_NC, PIRQ_NC, PIRQ_NC} }, /* USB XHCI: 0:10.00 - IRQ 5 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131817): https://review.coreboot.org/c/coreboot/+/58754/comment/c7afb5dc_31fa4af7 PS1, Line 30: {SATA_DEVFN, {PIRQ_SATA, PIRQ_NC, PIRQ_NC, PIRQ_NC} }, /* SATA: 0:11.00 - IRQ 7 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131817): https://review.coreboot.org/c/coreboot/+/58754/comment/d143d921_1bac6c7e PS1, Line 31: {OHCI1_DEVFN, {PIRQ_OHCI1, PIRQ_NC, PIRQ_NC, PIRQ_NC} }, /* USB OHCI1: 0:12.00 - IRQ 5 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131817): https://review.coreboot.org/c/coreboot/+/58754/comment/290b381e_19569edd PS1, Line 32: {EHCI1_DEVFN, {PIRQ_NC, PIRQ_EHCI1, PIRQ_NC, PIRQ_NC} }, /* USB EHCI1: 0:12.02 - IRQ 4 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131817): https://review.coreboot.org/c/coreboot/+/58754/comment/ac8bb898_42f48cb9 PS1, Line 33: {OHCI2_DEVFN, {PIRQ_OHCI2, PIRQ_NC, PIRQ_NC, PIRQ_NC} }, /* USB OHCI2: 0:13.00 - IRQ 5 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131817): https://review.coreboot.org/c/coreboot/+/58754/comment/60b95016_ce715edc PS1, Line 34: {EHCI2_DEVFN, {PIRQ_NC, PIRQ_EHCI2, PIRQ_NC, PIRQ_NC} }, /* USB EHCI2: 0:13.02 - IRQ 4 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131817): https://review.coreboot.org/c/coreboot/+/58754/comment/ec78f860_ba206d9a PS1, Line 35: {OHCI3_DEVFN, {PIRQ_OHCI3, PIRQ_NC, PIRQ_NC, PIRQ_NC} }, /* USB OHCI3: 0:16.00 - IRQ 5 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131817): https://review.coreboot.org/c/coreboot/+/58754/comment/9275bf93_ecc4307c PS1, Line 36: {EHCI3_DEVFN, {PIRQ_NC, PIRQ_EHCI3, PIRQ_NC, PIRQ_NC} }, /* USB EHCI3: 0:16.02 - IRQ 4 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131817): https://review.coreboot.org/c/coreboot/+/58754/comment/d89adee5_b2b0a98f PS1, Line 37: {HDA_DEVFN, {PIRQ_HDA, PIRQ_NC, PIRQ_NC, PIRQ_NC} } /* Southbridge HD Audio: 0:14.02 - IRQ 3 */ line over 96 characters
File src/mainboard/asus/am1i-a/mptable.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131817): https://review.coreboot.org/c/coreboot/+/58754/comment/b7d7976e_a297f883 PS1, Line 127: smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, (bus), (((dev)<<2)|(fn)), ioapic_id, (pin)) line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131817): https://review.coreboot.org/c/coreboot/+/58754/comment/a0ef288a_19b6b685 PS1, Line 173: smp_write_lintsrc(mc, (type), MP_IRQ_TRIGGER_EDGE | MP_IRQ_POLARITY_HIGH, bus_isa, (intr), (apicid), (pin)) line over 96 characters