Attention is currently required from: Sean Rhodes, Subrata Banik, Dinesh Gehlot, Paul Menzel, Lean Sheng Tan.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74511 )
Change subject: soc/intel/common: Don't hardcode ramtop offset
......................................................................
Patch Set 17:
(2 comments)
Patchset:
PS17:
Sorry, just found an old draft message... :-/
Aren't we basically back at PS#14. Was I wrong about the bits vs. bytes?
File src/soc/intel/common/basecode/ramtop/ramtop.c:
https://review.coreboot.org/c/coreboot/+/74511/comment/28628560_89bda9cc
PS14, Line 24: #endif // CMOS_VSTART_ramtop % 8 == 0
Sorry - I did test, it doesn't complain
Hmmm, for e.g. 1052 I'm getting:
```
...
OPTION option_table.h
nvramtool: Unaligned CMOS option table entry ramtop spans multiple bytes.
make: *** [src/arch/x86/Makefile.inc:28: build/option_table.h] Error 1
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74511
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5327b5d4e78b715a85072e5d9a62cf8fd2ae92c0
Gerrit-Change-Number: 74511
Gerrit-PatchSet: 17
Gerrit-Owner: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Dinesh Gehlot
digehlot@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Comment-Date: Wed, 10 May 2023 15:36:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Rhodes
sean@starlabs.systems
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment