Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33934 )
Change subject: lib: Rewrite qemu-armv7 ramdetect
......................................................................
Patch Set 6: Code-Review+2
(2 comments)
Other than two small things, LGTM
https://review.coreboot.org/c/coreboot/+/33934/6/src/lib/ramdetect.c
File src/lib/ramdetect.c:
https://review.coreboot.org/c/coreboot/+/33934/6/src/lib/ramdetect.c@22
PS6, Line 22: mib
Minor: I'd suggest using a different name to avoid confusion with the 'MiB' constant
https://review.coreboot.org/c/coreboot/+/33934/6/src/lib/ramdetect.c@30
PS6, Line 30: int
This could be an unsigned type, e.g. size_t?
Avoids having several signed/unsigned comparisons, since ARRAY_SIZE returns size_t
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33934
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I37386c6a95bfc3b7b25aeae32c6e14cff9913513
Gerrit-Change-Number: 33934
Gerrit-PatchSet: 6
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Asami Doi
d0iasm.pub@gmail.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Jonathan Neuschäfer
j.neuschaefer@gmx.net
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: Xiang Wang
merle@hardenedlinux.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Fri, 26 Jul 2019 13:48:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment