Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35214 )
Change subject: mb/google/kahlee/treeya: override sku_id() function ......................................................................
Patch Set 8:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35214/3/src/ec/google/chromeec/ec_b... File src/ec/google/chromeec/ec_boardid.c:
https://review.coreboot.org/c/coreboot/+/35214/3/src/ec/google/chromeec/ec_b... PS3, Line 31: uint32_t sku_id(void)
Some boards such as kukui/fizz/gru have themselves' implementation considering with CBI or without […]
Patch updated.
https://review.coreboot.org/c/coreboot/+/35214/4/src/ec/google/chromeec/ec_b... File src/ec/google/chromeec/ec_boardid.c:
https://review.coreboot.org/c/coreboot/+/35214/4/src/ec/google/chromeec/ec_b... PS4, Line 31: sku_id
Mark __weak flag here and make sure this sku_id function is default.
Patch changed.
https://review.coreboot.org/c/coreboot/+/35214/4/src/lib/coreboot_table.c File src/lib/coreboot_table.c:
https://review.coreboot.org/c/coreboot/+/35214/4/src/lib/coreboot_table.c@a2... PS4, Line 227:
- I thought that need remove sku_id here, make sure no other side effects. […]
Patch changed.