Attention is currently required from: Raul Rangel, Martin Roth, Furquan Shaikh, Marshall Dawson, Angel Pons, Andrey Petrov, Patrick Rudolph.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51575 )
Change subject: drivers/intel/fsp2_0/Kconfig: select HAVE_DISPLAY_MTRRS
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
maybe it would be a better idea to have a kconfig option to elect for x86 CPUs that support MTRRs that is then also used to include the MTRR code in the build instead of the corresponding makefile being included in the SoC's makefile and wherever this gets included for the non-SoC code. then the HAVE_DISPLAY_MTRRS can just be dropped. i find having a kconfig option to include the MTRR code to be much cleaner than including the corresponding makefile. any opinions on this?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51575
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2894689ce58e7404d9d5a894f3c288bc4016ea19
Gerrit-Change-Number: 51575
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Tue, 07 Sep 2021 00:17:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment