Bill XIE has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39906 )
Change subject: drivers/pc80/rtc: Change the logic to use cmos.default to keep PCRs
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39906/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/39906/1//COMMIT_MSG@7
PS1, Line 7: Always load cmos.default to satisfy measured boot
The problem still remains... […]
Please review the actual change.
Should I keep two logically identical implementations and switch between them with conditional preprocessing just to save a file loading?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39906
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If6ea0d1cbaa7d96f7dea7e77b7548ca2b30efe9e
Gerrit-Change-Number: 39906
Gerrit-PatchSet: 4
Gerrit-Owner: Bill XIE
persmule@hardenedlinux.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 30 Mar 2020 10:53:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Bill XIE
persmule@hardenedlinux.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment