[coreboot-gerrit] [S] Change in coreboot[master]: mb/google/brya: fix GPP_H13 setting for brya0 and skolas

[Felix Held (Code Review)]

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/70512 )

Change subject: mb/google/brya: fix GPP_H13 setting for brya0 and skolas
......................................................................

mb/google/brya: fix GPP_H13 setting for brya0 and skolas

The EN_PP3300_SD gpio (GPP_H13) was configured as a no-connect, but
should be configured as an output.

This change configures GPP_H13 on brya0 and skolas to be an output.

BUG=b:261901759
BRANCH=firmware-brya-14505.B
TEST="emerge-brya coreboot chromeos-bootimage" and verify skolas boots.

Change-Id: Ia3f01e877a5fea3af9a6e746523ed395f3af3b8a
Signed-off-by: Nick Vaccaro 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/70512
Reviewed-by: Eric Lai 
Reviewed-by: Subrata Banik 
Tested-by: build bot (Jenkins) 
---
M src/mainboard/google/brya/variants/brya0/gpio.c
M src/mainboard/google/brya/variants/skolas/gpio.c
2 files changed, 28 insertions(+), 3 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Subrata Banik: Looks good to me, approved
  Eric Lai: Looks good to me, approved

diff --git a/src/mainboard/google/brya/variants/brya0/gpio.c b/src/mainboard/google/brya/variants/brya0/gpio.c
index cab187a..f406f4b 100644
--- a/src/mainboard/google/brya/variants/brya0/gpio.c
+++ b/src/mainboard/google/brya/variants/brya0/gpio.c
@@ -114,7 +114,7 @@
    /* H11 : UART0_TXD ==> UART_PCH_TX_DBG_RX */
    PAD_CFG_NF(GPP_H11, NONE, DEEP, NF2),
    /* H13 : I2C7_SCL ==> EN_PP3300_SD */
-	PAD_NC(GPP_H13, UP_20K),
+	PAD_CFG_GPO(GPP_H13, 1, DEEP),
 };

/* Early pad configuration in bootblock for board id 4 */
@@ -160,7 +160,7 @@
    /* H11 : UART0_TXD ==> UART_PCH_TX_DBG_RX */
    PAD_CFG_NF(GPP_H11, NONE, DEEP, NF2),
    /* H13 : I2C7_SCL ==> EN_PP3300_SD */
-	PAD_NC(GPP_H13, UP_20K),
+	PAD_CFG_GPO(GPP_H13, 1, DEEP),
 };

static const struct pad_config romstage_gpio_table[] = {
diff --git a/src/mainboard/google/brya/variants/skolas/gpio.c b/src/mainboard/google/brya/variants/skolas/gpio.c
index cab187a..3485e18 100644
--- a/src/mainboard/google/brya/variants/skolas/gpio.c
+++ b/src/mainboard/google/brya/variants/skolas/gpio.c
@@ -27,6 +27,8 @@
    PAD_CFG_GPO(GPP_F20, 0, DEEP),
    /* F21 : EXT_PWR_GATE2# ==> WAKE_ON_WWAN_ODL */
    PAD_NC(GPP_F21, NONE),
+	/* H13 : I2C7_SCL ==> EN_PP3300_SD */
+	PAD_CFG_GPO(GPP_H13, 1, DEEP),
    /* H21 : IMGCLKOUT2 ==> WLAN_INT_L */
    PAD_CFG_GPI_APIC(GPP_H21, NONE, DEEP, EDGE_SINGLE, NONE),
    /* GPD2: LAN_WAKE# ==> NC */
@@ -69,7 +71,7 @@
    /* H11 : UART0_TXD ==> UART_PCH_TX_DBG_RX */
    PAD_CFG_NF(GPP_H11, NONE, DEEP, NF2),
    /* H13 : I2C7_SCL ==> EN_PP3300_SD */
-	PAD_NC(GPP_H13, UP_20K),
+	PAD_CFG_GPO(GPP_H13, 1, DEEP),
 };

/* Early pad configuration in bootblock for board id 2 */