[coreboot-gerrit] Change in ...coreboot[master]: nb/amd/amdfam10: Use 64 bits in multiplication

[Jacob Garber (Code Review)]

Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33210 )

Change subject: nb/amd/amdfam10: Use 64 bits in multiplication
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/33210/1/src/northbridge/amd/amdfam10/northbr... 
File src/northbridge/amd/amdfam10/northbridge.c:

https://review.coreboot.org/#/c/33210/1/src/northbridge/amd/amdfam10/northbr... 
PS1, Line 794: 				qword = (uint64_t)0x1000000 * num_nodes;
> Would 0x1000000UL or so also work?

I don't think so. UL is unsigned long, which is 32 bits for us. Of course, it could be something different on other platforms, which is the problem with these integer literal suffixes. The "standard official" way is to use a macro like UINT64_C(), but by then you might as well just use a cast anyway.