Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44586 )
Change subject: mb/google/dedede: Add support to override gpio config in bootblock ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44586/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44586/5//COMMIT_MSG@7 PS5, Line 7: Add support to override gpio config in bootblock This generally doesn't work well and results into lot of manual errors. The override table works under the assumption that the GPIO in the override table already has an entry in the base table. If there is no entry in the base table, then adding it to override table causes it to simply not take effect. It is easy to miss out on this fact and run into silent failures.