Daniel H Kang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42048 )
Change subject: mb/google/volteer: Fix VCM and EEPROM configs for ov8856 world-facing camera
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42048/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/42048/2//COMMIT_MSG@7
PS2, Line 7: UPTREAM
This *is* upstream 😊 please remove
Done
https://review.coreboot.org/c/coreboot/+/42048/2//COMMIT_MSG@10
PS2, Line 10: Volteer proto 2 camera module's VCM and EEPROM configs.
suggestion: Current version of Volteer has a different camera than previous revisions and its MIPI c […]
Hi Tim,
The camera definitions are correct but only VCM and EEPROM configs were not matching to Volteer proto 2, and also proto 1 because the world-facing camera (RCAM) is the same for both revisions.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42048
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I792608f86a59b16545dfa4edf6508de7a444bb26
Gerrit-Change-Number: 42048
Gerrit-PatchSet: 4
Gerrit-Owner: Daniel Kang
daniel.h.kang@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Alex Levin
levinale@chromium.org
Gerrit-Reviewer: Andy Yeh
andy.yeh@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Daniel H Kang
daniel.h.kang@intel.corp-partner.google.com
Gerrit-Reviewer: Dossym Nurmukhanov
dossym@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Reviewer: JasonX Z Chen
jasonx.z.chen@intel.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Tian Shu Qiu
tian.shu.qiu@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Andy Yeh
andy.yeh@intel.com
Gerrit-CC: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Comment-Date: Wed, 17 Jun 2020 15:39:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment