build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27665 )
Change subject: mb/pcengines/apu2: change GPIO setting
......................................................................
Patch Set 7:
(3 comments)
https://review.coreboot.org/#/c/27665/7/src/mainboard/pcengines/apu2/gpio_ft...
File src/mainboard/pcengines/apu2/gpio_ftns.c:
https://review.coreboot.org/#/c/27665/7/src/mainboard/pcengines/apu2/gpio_ft...
PS7, Line 27: + gpio));
code indent should use tabs where possible
https://review.coreboot.org/#/c/27665/7/src/mainboard/pcengines/apu2/gpio_ft...
PS7, Line 27: + gpio));
please, no space before tabs
https://review.coreboot.org/#/c/27665/7/src/mainboard/pcengines/apu2/romstag...
File src/mainboard/pcengines/apu2/romstage.c:
https://review.coreboot.org/#/c/27665/7/src/mainboard/pcengines/apu2/romstag...
PS7, Line 116: if (IS_ENABLED(CONFIG_BOARD_PCENGINES_APU5)) {
braces {} are not necessary for single statement blocks
--
To view, visit
https://review.coreboot.org/27665
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf4a60acabe65cd7f9985bb3af8bd577764d4196
Gerrit-Change-Number: 27665
Gerrit-PatchSet: 7
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Elyes HAOUAS
ehaouas@noos.fr
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: kamran javed
kamrangulhaji315a@gmail.com
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 03 Aug 2018 10:30:00 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No