[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/block/smm: add case intrusion to SMI handler

[Patrick Georgi (Code Review)]

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39265 )

Change subject: soc/intel/common/block/smm: add case intrusion to SMI handler
......................................................................

Patch Set 8:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39265/5/src/soc/intel/common/block/... 
File src/soc/intel/common/block/smm/smihandler.c:

https://review.coreboot.org/c/coreboot/+/39265/5/src/soc/intel/common/block/... 
PS5, Line 444: 	if (tco_sts & (TCO_INTRD_DET << 16)) { /* INTRUDER# assertion */
> I had that idea, too, but I wasn't sure if anyone would be happy with introducing more weak function […]

Generally speaking we add such infrastructure as soon as the first real user shows up. So yes, that probably should be a callback, but not until there's a non-default implementation for it.